-
Notifications
You must be signed in to change notification settings - Fork 2
Minor edit suggestions by @TallTed #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Ted Thibodeau Jr <[email protected]>
The Echidna run for this PR failed as the whole repo seems to be out of date with respect to the global |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebasing should mean this PR only has changes for spec/index.
Yes, indeed. Perhaps I made a mistake in the way I rebased (I am not doing that so often). In my local version of the feature branch for this PR, I did:
After that, I did:
But the latter (
I did the second (because I thought that this is what I have to do in order to rebase). After that, |
d444c57
to
7f23944
Compare
The branch now has rewritten the 2 commits from main (different hashes) on top of your changes. that wil show up when merged to main (probbaly "skipped previously applied commit"). After Solution:
and now the branch has the commit from main (same hash) and will be rebase-and-merge compatible with As I've got that locally, I'll "push -f" the PR branch. (after - now 1 file changed). |
Thanks! |
This PR implements a few edit suggestions that @TallTed had on commit f4977ce in PR #245 after the PR was already merged.
@TallTed, I included all your suggestions except for the one about code-fencing the keyword SELECT. That one I left out because, in this part of the spec, there are a lot of mentions of SPARQL keyword and none of them is code-fenced. Thus, code-fencing just this one mention of "SELECT" would be inconsistent with respect to the rest of this part of the spec.
Preview | Diff